[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 I am closing this to create a new one based on the new JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 I oups not the ubuntu, the non-alpine one :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 I will, and add the commits for the ubuntu image, probably I will create a JIRA for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 Since this PR is no longer directly related to publishing official Docker images, could you change its title? (See my reply to your comment on #3494) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 Aha, I see. I didn't follow the chain up further. :) Then yes, I'm generally on board with following this convention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 Yes, maybe I was not clear enough, my goal is to support the two variants of openjdk that you mention. I was just mentioning ubuntu/debian because this is the base of the non-alpine base container for openjdk. https://github.com/docker-library/openjdk/blob/445f8b8d18d7c61e2ae7fda76d8883b5d51ae0a5/8-jre So we will need some small tweaks and an extra Dockerfile to support both. For other images that support both openjdk base and the alpine version. https://hub.docker.com/_/solr/ https://hub.docker.com/_/jenkins/ https://hub.docker.com/_/tomcat/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 I've opened my PR, #3494. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 I took a look through the [top official Docker](https://hub.docker.com/explore/) repos to see what variants they provide, and the first-listed Java-based project is [Elasticsearch](https://hub.docker.com/_/elasticsearch/). They have two variants for each of their supported version, alpine and non-alpine which are based on openjdk:8-jre and openjdk:8-jre-alpine respectively. Can you point me at other official repos basing on debian/ubuntu images? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 Cool ! Just ping me when you are done and I will rebase to finish the clean ups, I am going to start contacting the docker people to see what else do we need and continue to work in the ubuntu version meanwhile (I think having both is worth even if it was me who slimmed the thing into alpine). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3493 Thanks @iemejia. I have a branch building on @jgrier's commits from #3205 which I hope to push before any further changes are made. Hopefully I can get it done today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 R: @greghogan cc: @jgrier @patricklucas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
