[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 Thanks, @tzulitai! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3911 I think this LGTM now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3911 Okay --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 Therefore I was waiting for that to get resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 I think it is, but I was never sure with all the test timeouts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3911 I think the change is okay to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 Scratch that, there is still a problem that the tests sometimes fail because of ``` org.apache.kafka.clients.consumer.RetriableCommitFailedException: Commit offsets failed with retriable exception. You should retry committing offsets. Caused by: org.apache.kafka.common.errors.GroupCoordinatorNotAvailableException: The group coordinator is not available. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 I think the last kinks are now ironed out. Could you please take another look? (anyone interested) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 Oh oh, that's a typo, yes. I can also change to `test-infra`, since we have several folders that are not maven sub modules already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3911 @aljoscha, okay, here the directory is perhaps mistyped `.test-infa`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 @greghogan No specific reason, to be honest. I took my inspiration for this from Beam, where we also have a `.test-infra` directory: https://github.com/apache/beam. I don't know why we have it there, maybe because normally only Maven sub-modules are visible directories. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3911 @aljoscha why a hidden directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 @rmetzger Yes, the test deletes the log files so that additional tests will start from a clean slate. I might be able to modify the Flink config so that each test gets it's own log directory. Could it be that you already had some log files in your `build-target` Flink installation? This would cause the test to fail if they contain errors/exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3911 I tried it locally, but got some weird results: ``` Found error in log files. Found exception in log files. Found non-empty file build-target/log/flink-robert-jobmanager-0-robert-da.out Found non-empty file build-target/log/flink-robert-taskmanager-0-robert-da.out One or more tests FAILED. ``` It seems that the script deleted the log files. Is that intended? Also it seemed that WC was running correctly, so I wonder why it failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 R: @rmetzger for review, please ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
