[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 I created a hotfix for the discussed issue: #4089 . I will close this PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 @dawidwys Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 @dawidwys I merged to master, now I rebased on `release-1.3` and running tests before merging there as well. Thanks for fixing this so quickly! 👌 --- If your project is set up for it,

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4039 Cool, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 I will address them today. I am working on last comment with enabling the changes also for Partitioner. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4039 @dawidwys What's your schedule to address the comments? This is one of the real blockers for the 1.3.1 release, and I would like to put the first RC this week. --- If your project is set up

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 Now, let's wait for @twalthr in case he has any comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 Thanks, and yes, I see my mistake now. I'll review, but could you please also have a look, @twalthr? I think you have more experience with this than I do. --- If your project is set up

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 I think it is ready for a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 In fact `new int[] {0,1,0,0}`, but I think you got the point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 Ah, so it performs nested navigation. If I had a type like ``` public interface Dummy { OUT apply(Map> value) } ``` it would be `new int[]

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 Sure, with the arrays you provide index of the input/output parameters in lambdas. The lambdaInputTypeArgumentIndices[0] is the argument index of lambda function. The

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4039 I like the idea of explicitly passing the argument parameters a lot! I would even suggest to remove the old methods with `hasCollector` and so on instead of just deprecating. Could you

[GitHub] flink issue #4039: [FLINK-6783] Changed passing index of type argument while...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4039 The PR is not fully ready yet, but as it touches critical part, I would like to hear early opinions from somebody more experienced with the Type system. Would be good to know if I am going the