Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys Thanks for the reviews and comments, please change the
documentation during merge.
And @kl0u , thanks for the reviews!
---
If your project is set up for it, you can reply to this em
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4331
I think you can merge it @dawidwys .
I was following the evolution of this PR and I think it looks good ;) .
Thanks for the work both @yestinchen and @dawidwys !
---
If your project is set up
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
Hi @dawidwys , sorry for the late response.
Thanks for your reviews, I have updated the test and the document. Please
take a look if you have time. Thanks.
---
If your project is set up for
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4331
Still missing some tests:
- ensuring the `NFA#extractCurrentMatches` returns patterns in order.
- skip to first/last with `oneOrMore`
Docs missing
---
If your project is set up
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
Thanks for your reviews @dawidwys ! I'll update the doc in the following
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys @dianfu I've updated the approach according to the document. Feel
free to comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dianfu Thanks for your reviewing.
I found @dawidwys wrote a draft about the JIRA's implementation. I'll go
through that first and address those issues in this PR latter.
---
If your projec
Github user litrain commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys @yestinchen Thanks for your discussion, I am also working on the
empty match issue now. Please have a look at
https://issues.apache.org/jira/browse/FLINK-7292.
---
If your project is s
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4331
Hi @yestinchen
Thanks for your feedback.
Right now, I just want to address the empty match issue. It is not easy to
apply that definition to unbounded data. In the SQL specificati
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4331
Sorry for late response. I think this feature is very useful and agree that
we should have a clear thought on what things should be for each skip strategy.
I noticed that there are already some discus
Github user yestinchen commented on the issue:
https://github.com/apache/flink/pull/4331
@dawidwys Thanks for the reviewing.
Problem 1 is easy to fix, we can just start a new match process if the only
left computation state reaches stopState.
Problem 2 can not be avoided
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4331
Hi @yestinchen ,
Thanks for the update.
After second round of review. I found many problems with current approach.
It returns only the first match in a stream in most cases.
1.
12 matches
Mail list logo
