[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4458 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4458 We can't do it just for final modifiers unfortunately. We _could_ look into creating a custom checkstyle rule based on `https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierCheck.java` with minor modifications. This should be rather straight-forward. That said, i think that it is unlikely that these modifiers would be removed by some auto-formatting, so they will neither clutter up diffs nor cause any functional problems (because well, they're _redundant_ after all). We could just keep them... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4458 Thanks for picking this up quickly. I assume there is no way to make this only about `final` modifiers? We could also approach this by doing selective exclusions of classes (like the Memory Segments) where the rule fires, but we want to retain the identifiers. There should not be too many, final methods in final classes are a very selective thing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
