[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4488 @wuchong could you take a look at #4532 as well? It is based on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4488 @wuchong No problem. Thursday is fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4488 @twalthr I'm working on other issues before Thursday, so I would like to have a look at it at Thursday (Beijing). But if you are hurry, I'm fine to merge this first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4488 @wuchong @sunjincheng121 @shaoxuan-wang do you also want to take a look at it? Otherwise I would merge this and work on the followup issue for more efficiency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4488 I'm fine with a followup issue. +1 to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4488 Thanks for the review @twalthr. I addressed your comments and updated the PR. I think it would be very good to handle the timestamps internally as longs. The change seems to be a bit more involved because we need to touch the serialization logic and various type conversion and code generation issues. I'd rather do this as a follow up to this PR. What do you think? Fabian --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
