[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4492 Thanks for the review @zentol. Rebasing onto the latest master and if Travis gives green light, then I'll merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4492 @zentol I've created the [WebOptions PR](#4512) and rebased onto that as you've requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4492 Alright, I'll port the web monitor options and rebase this PR onto that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4492 Thanks for testing things on yarn/HA. As for the web monitor options, I do see the point of not coupling new options to the jobmanager. However, I think it's a bad idea to have some be tied to the jobmanager while others aren't. This smells like a repeat of the ConfigOption introduction, where we approached things with a "let's refactor the rest later" mentality, and that still isn't complete. I suggest to port all webmonitor options first (with deprecates keys obviously), and then rebase the PR on top of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4492 I did the additional tests running Flink on Yarn with and without HA and the web frontend worked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4492 Thanks for the review @zentol. I've addressed most of your comments modulo the web frontend configuration options and rebased the PR onto the latest master. I've tested the web frontend locally with a standalone cluster but not with Yarn and HA. Will try these configuration out as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorG...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4492 This PR also needs a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
