[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5

2017-08-09 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4494 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5

2017-08-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4494 @zentol I think it should be safe to remove that asm relocation (for Kinesis, as far as I'm aware of). --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5

2017-08-09 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4494 Thank your for the review @greghogan . I made 2 more changes to the kinesis/shaded-curator poms; they were including/relocating asm in their shade-plugin configuration even though neither appears to

[GitHub] flink issue #4494: [FLINK-7026] Introduce flink-shaded-asm-5

2017-08-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4494 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the