[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-20 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
Rebased onto the latest master. Once Travis gives green light, I'll merge 
this PR.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-16 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
Alright, I'll change the PR.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-13 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4805
  
let's put iut under /jobs then for now.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-12 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
I'm not entirely sure, but I think we cannot put the `JobsOverviewHandler` 
under `/jobs/overview`. The problem is that it collides with `/jobs/:jobid`. If 
I access `http://localhost:8081/jobs/overview` I get a 
`java.lang.IllegalArgumentException: contains illegal character for hexBinary: 
overview`. Not sure why it works when the call comes from the web ui.

So either we don't do this change or we register the handler under `/jobs`. 
Then we would simply return a detailed view when accessing jobs. In the future 
we could add an optional filter statement to not include all information. What 
do you think @zentol?


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-12 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
I reverted the changes to `vendor.css` and `vendor.js` and updated the 
`rest_api.md`.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-12 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
Alright. I'm wondering whether it would be possible to somehow fix these 
things because this is bound to be changed.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-12 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4805
  
Often happens due to different dependency/build system versions of even OS 
specific oddities. I typically just revert those changes.


---

[GitHub] flink issue #4805: [FLINK-7806] [flip6] Register CurrentJobsOverviewHandler ...

2017-10-11 Thread tillrohrmann 
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4805
  
Not sure why the changed @zentol. I just executed the build process as it 
was described in the readme.


---