[GitHub] flink issue #4915: [FLINK-7838] Bunch of hotfixes and fix missing synchroniz...

2017-11-02 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4915 Fine for me, thanks! ---

[GitHub] flink issue #4915: [FLINK-7838] Bunch of hotfixes and fix missing synchroniz...

2017-11-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4915 I've added a commit to rename the 011 producer integration test to `ITCase`. Please let me know if you disagree with that @pnowojski @GJL. ---

[GitHub] flink issue #4915: [FLINK-7838] Bunch of hotfixes and fix missing synchroniz...

2017-11-01 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4915 Thanks for the work and reviews @GJL @pnowojski. I did a pass also, changes LGTM. Left one last comment regarding the integration test class name. Other than that, would like to merge

[GitHub] flink issue #4915: [FLINK-7838] Bunch of hotfixes and fix missing synchroniz...

2017-10-27 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4915 👍 ---

[GitHub] flink issue #4915: [FLINK-7838] Bunch of hotfixes and fix missing synchroniz...

2017-10-27 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4915 @GJL @aljoscha could you take a look? ---