[GitHub] flink issue #5048: [Flink-7871] [flip6] SlotPool should release unused slots...

2018-02-09 Thread ifndef-SleePy
Github user ifndef-SleePy commented on the issue:

https://github.com/apache/flink/pull/5048
  
Hi @tillrohrmann , I just updated the PR, sorry for delaying so long. 


---


[GitHub] flink issue #5048: [Flink-7871] [flip6] SlotPool should release unused slots...

2018-01-09 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5048
  
Hi @ifndef-SleePy, did you find time to rebase your PR onto the latest 
master? If you need help, then let me know.


---


[GitHub] flink issue #5048: [Flink-7871] [flip6] SlotPool should release unused slots...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5048
  
Thanks a lot @ifndef-SleePy.


---


[GitHub] flink issue #5048: [Flink-7871] [flip6] SlotPool should release unused slots...

2017-12-04 Thread ifndef-SleePy
Github user ifndef-SleePy commented on the issue:

https://github.com/apache/flink/pull/5048
  
Hi Till, thank you for reviewing.

I agree that it is much simpler to use `scheduleRunAsync`.

[PR-5091](https://github.com/apache/flink/pull/5091) is not a small 
reworking. But it looks really great to me. Will rebase it and address comments 
in a few days.


---