[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2018-02-14 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5185 Thanks for the update. Regarding migration, I think the format that we write to the savepoint must be the same between the two `ListState` implementations. @StefanRRichter could you please

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2018-02-11 Thread je-ik
Github user je-ik commented on the issue: https://github.com/apache/flink/pull/5185 @aljoscha I (partly) reworked this PR as you suggest. There are still some unresolved questions though: 1) I'm not 100% sure how to cleanly support the migration between list state savepoints,

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2018-01-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5185 The concept of this looks good. However, if we want to merge it I think we have to make this a standalone thing and not depend on other states because this can have unforeseen consequences for

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2017-12-21 Thread je-ik
Github user je-ik commented on the issue: https://github.com/apache/flink/pull/5185 I think that the failed test is not related to this PR. ---

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2017-12-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5185 This might be a great chance to start discussing how ListState APIs should evolve - specifically, is it time to consider adding `remove()` to ListState? ---