[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-05 Thread twalthr 
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/5367
  
Btw I will remove the null tests because fields of tuples and case classes 
are not allowed to be null. The serializers would throw an exception.


---

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-05 Thread twalthr 
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/5367
  
Thanks for the update @suez1224. The changes look good. I will merge this...


---

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-02 Thread suez1224 
Github user suez1224 commented on the issue:

https://github.com/apache/flink/pull/5367
  
@hequn8128 @twalthr could you please take another look? I've refactored the 
code to reuse the generateFieldAccess() code, also added null test. Nested 
tuple wont work now due to https://issues.apache.org/jira/browse/CALCITE-2162. 
I've submitted a PR to fix it in Calcite.


---

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-01 Thread suez1224 
Github user suez1224 commented on the issue:

https://github.com/apache/flink/pull/5367
  
@hequn8128 , thanks for the review. Where do you think we can add it in 
sql.md?


---

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-01-26 Thread suez1224 
Github user suez1224 commented on the issue:

https://github.com/apache/flink/pull/5367
  
@twalthr rebased, could you please take another look? Thanks a lot.


---