[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Actually , I want do some test under the latest master code. ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Hi, @StephanEwen .Sorry for later. 1. For the first question, I do not have a machine for this test at this moment and wont test it until I have a linux machine. Can not get a linux machine at my environment, even a virtual machine. also can not afford a Apple computer. 2. I agree with you at this point. Size is a confused number in a way. I did not see there is a shell scripts rotates the log file before. ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Two more questions about this: 1. There is code in the shell scripts that rotates log file each time you start / stop the cluster, with .0 /.1/.2/etc suffixes to the log files. Have you tested whether that still works with the changed setup? 2. I think rolling by time is something that users expect more commonly that rolling by size. What do you think here? ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen review. Yea, You correct. DailyRollingFileAppender doesn't support MaxFileSize, RollingFileAppender does. I will changed the code to a correct version and wait for the CI ending. ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 The CI Server reports the following problem below. Apparently the configurations cause warnings to be printed. Can you have a look at that? ``` Found non-empty .out files: log4j:WARN No such property [maxBackupIndex] in org.apache.log4j.DailyRollingFileAppender. log4j:WARN No such property [maxFileSize] in org.apache.log4j.DailyRollingFileAppender. log4j:WARN No such property [maxBackupIndex] in org.apache.log4j.DailyRollingFileAppender. log4j:WARN No such property [maxFileSize] in org.apache.log4j.DailyRollingFileAppender. One or more tests FAILED. ``` ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Changed! ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 I watched and the Travis error does not relevant to this issue. ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 I have changed the code, @StephanEwen @XuMingmin Welcome to review those codes ~ Thanks. I make the ```MaxFileSize``` to 200MB and storage for 30 days now. ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen ~ ---
[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Looks good! ---
