Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
@pnowojski , I have changed the `EXACTLY_ONCE_BLOCKING_DATA_ENABLED` as
true and squashed the commits.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
Thanks for rebasing the conflicts.
Yes, the default value can be changed to true after the credit-based is
totally merged. If need any changes on my side after all, pls let me know. :)
--
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
@pnowojski , I have submitted the updates for above comments.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
@pnowojski , thanks for suggestions and I totally agree with that.
That abstraction indeed makes the code simple. I will update the codes
ASAP.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
@pnowojski , I have submitted a separate commit to address above comments.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/5400
@pnowojski , thanks for reviews!
I understand your concerns and I should deduplicate some common utils in
these tests. I will do that tomorrow together with other comments!
---
