Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5486
+1 to merge.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
@kl0u I changed my mind on this. ð
Now the only change is to allow
circumventing the `truncate()` checks via the setting. The checks themselves
are still in place. I'm also not changing the call-
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5486
@aljoscha Yes it does. I did not get it in the first place but I think that
this clarifies things!
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
@kl0u Thanks for the review!
I changed the code to check `useTruncate` before calling. Regarding
`fsConfig`, the settings in there are for `FileSystem` while the settings that
are configure
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
(I realised this doesn't add any tests or anything but `BucketingSink` is
currently problematic with S3 anyways.)
---
