[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/5490
  
Thanks for the correction, LGTM 👍


---


[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-17 Thread sihuazhou
Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5490
  
@StefanRRichter If that is outdated, could you please merge this PR to fix 
it?


---


[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/5490
  
Yes, that is outdated.


---


[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-16 Thread sihuazhou
Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5490
  
Aha, I got it. But I also found the description of Memory state backend is 
wrong in these PR, the description is `The MemoryStateBackend can be configured 
to use asynchronous snapshots. While we strongly encourage the use of 
asynchronous snapshots to avoid blocking pipelines, please note that this is a 
new feature and currently not enabled by default.`, but I found `asynchronous 
snapshots` is enabled by default, it seems like out of date, could you please 
also have a look ? @StefanRRichter 


---


[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/5490
  
The docs are not "incorrect" and this is on purpose. Background is that, in 
general, externalized checkpoints are only required to support a subset of the 
features that savepoints provide and we do not want that user rely on their 
checkpoints to be rescalable. While this might be true now, this might change 
for all or some implementations in the future, so we simply do not want to give 
a guarantee that we then must maintain.


---


[GitHub] flink issue #5490: [FLINK-8657][doc]Fix incorrect description in the documen...

2018-02-15 Thread aljoscha
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/5490
  
@StefanRRichter Could you have a look at this?


---