[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5535 will merge this, as is, once travis gives a green light. The commits have the rather nice property that they don't require changes to other classes (like the MiniClusterResource); wouldn't want to

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5535 I'm removing `AccumulatorErrorITCase` from the port due to FLINK-8721. ---

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 Thanks @zentol. Yea. I agree with you. ---

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5535 yes, as mentioned in PR the description this does not port all tests. There are several tests that cannot be ported in isolation as they access specific methods on the `LocalFlinkMiniCluster` or

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 And we also seems lost refactor ```WebFrontendITCase``` which still use ```LocalFlinkMiniCluster```. ---

[GitHub] flink issue #5535: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5535 JobManagerHACheckpointRecoveryITCase still use ```LocalFlinkMiniCluster``` as it's default one. And we seem to be lost refactor it. And I dont think it is a very easy work since in this