Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5638
Thanks for the PR @buptljy!
As mentioned in the comment, the function should be exposed similar to
`ln()` and `log10()` as `expr.log(base)`. For that the expression parser would
need to be a
Github user buptljy commented on the issue:
https://github.com/apache/flink/pull/5638
@walterddr What else should I do for this PR ?
---
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5638
Thanks for the explanation @buptljy. Yeah if that's the case the only way
to validate is via ITCase, it might be an overkill in this situation though.
---
Github user buptljy commented on the issue:
https://github.com/apache/flink/pull/5638
@walterddr As explained in
[FLINK-8930](https://issues.apache.org/jira/browse/FLINK-8930), the reason that
"LOG(-1)" and "LOG(1, 100)" succeed is that they're simplified in calcite's
evaluation, whi
Github user buptljy commented on the issue:
https://github.com/apache/flink/pull/5638
@walterddr I'm not able to add a validation test because I am blocked by
[FLINK-8930](https://issues.apache.org/jira/browse/FLINK-8930).
---
Github user buptljy commented on the issue:
https://github.com/apache/flink/pull/5638
@suez1224 Docs are added in both java and scala.
---
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5638
The PR looks good. Could you please add documentation in
docs/dev/table/tableApi.md for both java and scala? Thanks.
---
