Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5649
I am rather against this change. Mainly because the tests that you moved
are not the only ones that operate on KeyedStream. In fact most of the tests in
`DataStreamTest` operate on keyed stream.
-
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
When I was developing KeyedProcessFunction, I initially wondered why
there's no tests for KeyedStream, and researched and realized that they were
actually mixed with DataStream tests.
I t
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5649
@bowenli86 What's your opinion? If you are ok with not merging it, could
you close this PR?
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5649
I am not sure about the value of those changes. The keying and the
`KeyedProcessFunction`s are applied onto `DataStream` plus tests in
`DataStreamTest` cover checks if the resulting stream is keyed
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
Hi @kl0u , can you pls take a look at this PR?
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5649
cc @kl0u
---
