[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 merging ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 checkstyle ð¡ ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5780 still failures because of this? ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 I may have found the case, we have to set `MANAGED_MEMORY_SIZE` for this test. ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5780 Failing reproducibly, and only on this branch? ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 travis is still failing with mysterious error messages.. ``` 15:58:07.061 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (integration-tests) on project flink-tests_2.11: ExecutionException: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? 15:58:07.061 [ERROR] Command was /bin/sh -c cd /home/travis/build/apache/flink/flink-tests/target && /usr/lib/jvm/java-8-oracle/jre/bin/java -Xms256m -Xmx2048m -Dmvn.forkNumber=1 -XX:+UseG1GC -jar /home/travis/build/apache/flink/flink-tests/target/surefire/surefirebooter5397929458643043612.jar /home/travis/build/apache/flink/flink-tests/target/surefire/surefire4818404066082555175tmp /home/travis/build/apache/flink/flink-tests/target/surefire/surefire_1027420331622776884606tmp ``` ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 I've cut down the PR to only not make any changes outside the tests, fixed the checkstyle violations and the failing test. ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5780 I would be fine with changing the PR to work against a `MiniCluster` (to drop the JobExecutor changes) and a `TemporaryFolder` that we manage ourselves, i,e. not as a `@Rule` (to drop the icky configuration changes). That's the quickest approach for now. ---
[GitHub] flink issue #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip6
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5780 The `ClassLoaderITCase` fails on Travis. There are also checkstyle violations: ``` 10:04:01.988 [ERROR] src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java:[62,15] (imports) UnusedImports: Unused import: org.junit.Assert.assertEquals. 10:04:01.988 [ERROR] src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java:[65,15] (imports) UnusedImports: Unused import: org.junit.Assert.fail. ``` ---