[GitHub] flink issue #5848: Minor cleanup of Java example code for AsyncFunctions

2018-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5848 Thanks a lot! Merging this in the next merge batch... ---

[GitHub] flink issue #5848: Minor cleanup of Java example code for AsyncFunctions

2018-04-16 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/5848 lgtm ---

[GitHub] flink issue #5848: Minor cleanup of Java example code for AsyncFunctions

2018-04-16 Thread kkrugler
Github user kkrugler commented on the issue: https://github.com/apache/flink/pull/5848 Hi @tedyu - not able to assign you as a reviewer, I guess I would need more Git fu to be able to do that. ---

[GitHub] flink issue #5848: Minor cleanup of Java example code for AsyncFunctions

2018-04-16 Thread kkrugler
Github user kkrugler commented on the issue: https://github.com/apache/flink/pull/5848 BTW, how do people check .md editing results before pushing? I've tried a few different plugins and command line utilities, but the mix of HTML and markdown has meant none of them render properly.