Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/6001
Looks good, thanks, merging this...
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen fixed based on your suggestion
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @tzulitai @fhueske
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @fhueske changed and fixed a remained error before
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6001
Thanks for the fix @yanghua. I left a minor comment.
Otherwise +1 to merge.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6001
hi @medcv I think maybe it better to assign the issue to yourself before
working on that, this could help to avoid depulicate works(cause i notice that
you make the PRs without assigning to
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6001
@yanghua Thanks for the fix. I will close my PR as you addressed all the
issues in the ticket here.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
@StephanEwen does this has any problem need to change? it seems @medcv try
to fixed this issue before asking me.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6001
cc @zentol @tillrohrmann
---
