[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

[zentol]

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/6140
  
merging. @zjffdu Please open a follow-up issue for adding a test so we 
don't break this again.


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
@zentol  I have addressed the comments. Could you help take a look at it ? 
Thanks


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
ping @tillrohrmann 


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

[ruankd]

Github user ruankd commented on the issue:

https://github.com/apache/flink/pull/6140
  
Seen the same issue, my workaround is to have `JobManagerAddressOption` in 
`runOptions` which is in 
[Flink-1.4.2](https://github.com/apache/flink/blob/release-1.4.2/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java#L185)
 but removed in Flink-1.5.0. 

```
diff --git 
a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
 
b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
index 1588aac..4872928 100644
--- 
a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
+++ 
b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
@@ -183,6 +183,7 @@ public class CliFrontendParser {
Options options = buildGeneralOptions(new Options());
options = getProgramSpecificOptions(options);
options.addOption(SAVEPOINT_PATH_OPTION);
+   options.addOption(ADDRESS_OPTION);
return 
options.addOption(SAVEPOINT_ALLOW_NON_RESTORED_OPTION);
}
 
```


---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/flink/pull/6140
  
@tillrohrmann  Could you help review it ? Thanks


---