[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6170 alrighty, looks good to me, merging. ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol, thanks for reviewing. I've updated the PR, can you please take a look? ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol, do you have some time this week to review this? I can proceed with the other tests once I know that this is the right way to handle it :) ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 Hi @zentol, just a friendly reminder about this pull request :) ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol, I've updated the tests and all tests pass now. Please take a look when you get the chance. ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol , thanks for your comments. I'll take a look soon! ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6170 env.execute() should block until the job has finished execution, so your analysis may be incorrect. I can take a deeper look at possible semantic changes, but there are some conceptual issues I'd like to clear up first. ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol , please take a look when you get the chance. I think testSimpleAfterMatchSkip() is failing [here](https://api.travis-ci.org/v3/job/392551505/log.txt) because the program arrived at the assert statement before the result stream was fully added to the sink. This test was passing in the travis ci build of my fork. Maybe we can add a countdownlatch to control for the size of the array list VALUES? A rich sink function would then countdown upon closing. What would you suggest? ---
[GitHub] flink issue #6170: [FLINK-9563]: Using a custom sink function for tests in C...
Github user deepaks4077 commented on the issue: https://github.com/apache/flink/pull/6170 @zentol, thanks, will do! ---
