[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 @StephanEwen, if the original authors of the code had an intention of writing the code as it is now, I'll follow your advice and leave it as it is. ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 @zentol, @StephanEwen, thank you for explaining the question about hotfixes. I was not very clear about whether to create a jira or hotfix before. ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 Is the issue addressed here a bug? If not, and if it seems that the original authors of the code had an intention of writing the code as it is now, I would suggest to leave it as it is. ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 This would be clearly not a hotfix. As per the pull request template, contributors should use hotfixes mainly for typos and JavaDoc updates. ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6321 depends on how extensive they are, hotfixes should only be used very small changes. ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 @zentol, hi, there are two ways to contribute to flink project. one is create a `jira FLINK-` , another is `[hotfix] XXX`. for example, fix some checkstyle or code refactor, how to choose the best way to contribute ? ---
[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6321 The commit message includes the JIRA id now. ---
