Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-74310825
I'll probably merge this change tomorrow because I'm working on a bigger
change on the web frontend.
---
If your project is set up for it, you can reply to this email
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-74068773
Looks good. There is a small conflict with #384 , but we can try and fix
this while merging.
+1
---
If your project is set up for it, you can reply to this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73477910
Very nice work. I have one comment inline, otherwise +1 to go!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/374#discussion_r24315701
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/web/SetupInfoServlet.java
---
@@ -127,25 +134,42 @@ private void
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73478511
I've tried it out locally. Looks very nice. Thank you.
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73509674
@StephanEwen Thanks for your advice! I fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/374#discussion_r24298303
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -349,6 +349,11 @@ Actor with ActorLogMessages with
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73410413
@tillrohrmann Thanks for your advice. I will fix it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73409662
Hi Chiwan, thanks for your work. It looks really good. I had some just some
minor remarks.
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/374#discussion_r24298309
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -300,6 +300,16 @@ import
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/374
[FLINK-1179] Add button to JobManager web interface to request stack trace
of a TaskManager
This PR contains following changes:
* Add public constructors of
12 matches
Mail list logo
