Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73749137
Thanks @balidani.
And travis tests now pass :tada:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73547684
Simple renaming didn't seem to keep the history, so I did the filtering
again :)
Didn't you have the same problem when moving flink-addons to flink-staging?
Let
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434636
@rmetzger does this mean I need to do the history filtering magic again and
open a new pr?
@andralungu thanks a lot!
@balidani have you submitted yours?
---
If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434977
Great, thanks ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73366441
I'm really sorry that I've messed up this pull request by renaming
flink-addons to flink-staging :(
I was doing it in a rush Really sorry.
---
If your project
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72883525
@balidani that's OK :)
@cebe we've got the acknowledgement for you, thanks!
@andralungu has submitted hers today.
---
If your project is set up for it, you can
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72851434
Sorry, I will only be able to fill the form on Sunday, my internet
connection is horrible here. Is that ok?
Daniel
On Feb 2, 2015 3:53 PM, Carsten Brandt
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72359922
One more thing ;-)
Did we collect ICLAs from all people contributing significant parts to
Gelly?
---
If your project is set up for it, you can reply to this email
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72366219
@fhueske why is that needed? [Gelly is Apache
2.0](https://github.com/project-flink/flink-graph/blob/master/LICENSE) licensed
and Flink too:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71492121
Sure, XyzTest are unit tests which are executed in Maven's test phase.
These should execute rather fast. Everything that brings up a full Flink system
is an integration
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71507264
Tests renamed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71376640
Thank you.
Looks good. History is preserved and you addressed my comments.
+1 for merging it.
---
If your project is set up for it, you can reply to this
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71268972
that really sounds like great fun :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71204417
Yes. The package seems to be still wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71157010
I took the pull request and filtered the branch to move the files into the
`flink-addons/flink-gelly` directory (that worked better for me than the
subtree merge).
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70839009
Thank you all for the suggestions regarding preserving the commit history!
I'll try them out later today and see whether I can make it :)
---
If your project is set up for
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/326
[FLINK-1201] Add flink-gelly to flink-addons
This PR adds an initial version of Gelly, a graph API for Flink, to the
flink-addons project.
The development of Gelly took place as a collaboration on
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/326#discussion_r23252081
--- Diff:
flink-addons/flink-gelly/src/main/java/org/apache/flink/gelly/Edge.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70725539
Hi @rmetzger! Thanks for starting on it so fast ^^
Regarding the name, we thought it'd be nice to have one.. It was actually
@ktzoumas that came up with Gelly :)
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70744282
I also prefer flink-graph.
After having a quick look at the commits I would suggest to squash a couple
of them, e. g. fda6e4c, which is empty or 393902c which
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70759342
I'm very exited about this :-) I will have a look later as well.
Regarding the name: I like the name gelly, but would also prefer
flink-graph (or something along the
Github user ktzoumas commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70767467
I think Gelly has way more personality than flink-graph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70743431
Woot! :)
As for merging the streaming back then, it was @StephanEwen who came up
with the solution, pasting the important parts here:
BTW: I used
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/326#discussion_r23248831
--- Diff:
flink-addons/flink-gelly/src/test/java/org/apache/flink/gelly/test/TestWeaklyConnected.java
---
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70717064
Great, I'm super excited to see the graph API being offered to the main
project.
I'll start reviewing the code right away, to merge it as soon as possible.
26 matches
Mail list logo
