Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r23071236
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/KryoSerializer.java
---
@@ -185,6 +187,8 @@ private void
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/304#issuecomment-70231876
Change looks good except for comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22999053
--- Diff: flink-java/pom.xml ---
@@ -64,6 +64,18 @@ under the License.
version0.5.1/version
/dependency
+
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/304#issuecomment-70063665
I added to LICENSE AND NOTICE and also addressed the other issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22968592
--- Diff: flink-java/pom.xml ---
@@ -64,6 +64,18 @@ under the License.
version0.5.1/version
/dependency
+
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22968293
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
---
@@ -99,6 +104,7 @@ public void testCopy() {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22955775
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
---
@@ -99,6 +104,7 @@ public void testCopy() {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r22956572
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/KryoGenericTypeSerializerTest.scala
---
@@ -125,6 +133,7 @@ class
