[GitHub] flink pull request: [FLINK-1533] [runtime] Fixes NPE in the schedu...

2015-02-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/388


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1533] [runtime] Fixes NPE in the schedu...

2015-02-12 Thread tillrohrmann
Github user tillrohrmann commented on the pull request:

https://github.com/apache/flink/pull/388#issuecomment-74107842
  
Ok, I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1533] [runtime] Fixes NPE in the schedu...

2015-02-12 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/388#issuecomment-74080518
  
Good catch.

+1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-1533] [runtime] Fixes NPE in the schedu...

2015-02-12 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/388

[FLINK-1533] [runtime] Fixes NPE in the scheduler

Adds checks to the method ```Scheduler.getFreeSubSlotForTask``` to handle 
failed shared slot allocations. Before the slot was given to the 
```SlotSharingGroupAssignment``` without checking that it is not null. 
Consequently, a NullPointerException could occur in the 
```SlotSharingGroupAssignment```.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixScheduler

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #388


commit 604728df38c860ab111d0a7bf2d19c71a0d30c67
Author: Till Rohrmann 
Date:   2015-02-12T13:51:45Z

[FLINK-1533] [runtime] Fixes NPE in the scheduler where the allocated 
shared slots are not properly checked.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---