Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-97401561
Our travis builds are a bit unstable right now. I'm running some last tests
and then I'll merge this. Thanks for staying with this and working on my
requests! :smile:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-97068257
@aljoscha GOT IT .. Now the build success locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-96953776
Unfortunately, Travis cuts of the log if it is too long, like here:
https://travis-ci.org/aljoscha/flink/jobs/60177866 (that's from your pull
request). You have to click
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-96809741
@aljoscha I have run code format from Intellij, I think the problem should
be solved now ..
I have tried to read the travis build log, but I could not find the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-96565454
The tests are failing because you use spaces in you code for indentation.
Could you please change all indentation to tabs to satisfy the style checker?
---
If your
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-96418152
@aljoscha I have checked the Travic log. The problem is in Flink
Streaming, so why my branch failed ?!!
---
If your project is set up for it, you can reply to this
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95846017
The problem is, that I can't see it in the github interface. On what branch
are your changes? Could you please rebase them on top of the current master?
---
If your
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95866843
@aljoscha u were right.. I could not find the code on my repo, somehow it
was lost !!! ..
I have created a new PR now, #621 .. it has the same commit of #442
GitHub user Elbehery opened a pull request:
https://github.com/apache/flink/pull/621
[FLINK-1615] [java api] SimpleTweetInputFormat
A replacement for PR #442
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Elbehery/flink
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-95926348
The build still fails because of missing license headers in the model
package.
By the way, did you write the files in the model package yourself or were
they
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/621#issuecomment-96041144
@aljoscha Yes I wrote these Pojos myself, and I have tested the handler to
retrieve distinct data, coz the tweets has redundant fields.
I have added the
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95603365
@aljoscha you should be able to see it from the PR .. anyway this is mine
https://github.com/Elbehery/flink
---
If your project is set up for it, you can reply to this
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95570894
Where is your git repository? So that I can checkout your commit and merge
it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95512206
I did rebase against the master before creating the PR .. but this was long
time ago, could this be the problems for the conflicts ?!!
---
If your project is set up for
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-95511047
This looks good to merge. Any objections?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-92100736
@rmetzger Still not merged, any updates ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-85686759
The failure is not your fault. It failed because your code has been rebased
to a master version with failing tests.
---
If your project is set up for it, you can reply
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-84968643
@rmetzger I think it failed again, but I cant see the reason
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-84912485
I triggered another travis build:
https://travis-ci.org/rmetzger/flink/builds/55459787
---
If your project is set up for it, you can reply to this email and have your
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-83499608
@StephanEwen I have checked and I found that the RAT plugin is included in
parent pom.xml file. Shall I exclude the resources folder in flink-contribute,
or add the
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-83519001
@StephanEwen, I have removed the license from the resource file, excluded
it from RAT, and added the license file. Also I did rebase against
upstream/master, before
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-82254957
I have revised the commit .. All the files has the license header, except a
resource file which contains 4 tweets for testing purpose .. Could this be the
problem ?
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-82261434
DONE
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-82260288
Yes, this can be the problem. Can you add a licence header (with comments)
to this file?
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-81837584
Have a look at the build server logs. They still complain about unapproved
license headers.
---
If your project is set up for it, you can reply to this email and
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26284910
--- Diff:
flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java
---
@@ -0,0 +1,67 @@
+package
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26288077
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,62 @@
+package org.apache.flink.contrib;
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26285363
--- Diff:
flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java
---
@@ -0,0 +1,67 @@
+package
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26285316
--- Diff:
flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java
---
@@ -0,0 +1,67 @@
+package
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26289003
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26300742
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26299783
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-78480294
@rmetzger This is the standard Tweet format as per Twitter. Here You can
find [Twitter Official
Documentation](https://dev.twitter.com/overview/api/tweets). My parser
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26300021
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user Elbehery commented on the pull request:
https://github.com/apache/flink/pull/442#issuecomment-78480464
@StephanEwen I have added the license.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26296323
--- Diff:
flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java
---
@@ -0,0 +1,67 @@
+package
Github user Elbehery commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26296679
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r26288947
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/SimpleTweetInputFormatTest.java
---
@@ -0,0 +1,76 @@
+package org.apache.flink.contrib;
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/442#discussion_r25566598
--- Diff:
flink-contrib/src/main/java/org/apache/flink/contrib/tweetinputformat/io/SimpleTweetInputFormat.java
---
@@ -0,0 +1,67 @@
+package
GitHub user Elbehery opened a pull request:
https://github.com/apache/flink/pull/442
[FLINK-1615] [java api] SimpleTweetInputFormat
This is a contribution with a TweetInputFormat, Jira
[FLINK-1615](https://issues.apache.org/jira/browse/FLINK-1615).
This commit contains,
42 matches
Mail list logo
