Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-87967427
Thank you very much for the review Henry!
I addressed your feedback where applicable. I'll merge the change now.
---
If your project is set up for it, you can
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456302
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnCluster.java ---
@@ -106,70 +111,129 @@ public FlinkYarnCluster(final YarnClient
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456202
--- Diff:
flink-test-utils/src/main/java/org/apache/flink/test/util/TestEnvironment.java
---
@@ -80,7 +80,7 @@ public String getExecutionPlan() throws
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456299
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -265,12 +266,32 @@ protected int run(String[] args) {
}
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456233
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -89,15 +89,20 @@ public void setPrintStatusDuringExecution(boolean
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456244
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -569,15 +590,33 @@ protected int executeProgram(PackagedProgram
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27456228
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/operators/translation/CustomPartitioningGroupingTupleTest.scala
---
@@ -18,12 +18,12 @@
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-88136878
Awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-87817661
@rmetzger, the PR is too large to do effective review =(
Could you kindly summarize the significant changes made to fix this? For
example why introduce new class
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-87780049
A user I'm talking with offline depends on these changes.
I'm currently hardening the tests on Travis, once that's done I'll merge
the changes (probably in the next
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-87840336
I know that the PR is touching many components. I'll try to split up my
work into smaller parts.
In this case I didn't expect in the beginning that I need to change
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27452529
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/operators/translation/CustomPartitioningGroupingTupleTest.scala
---
@@ -18,12 +18,12 @@
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27452585
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnCluster.java ---
@@ -106,70 +111,129 @@ public FlinkYarnCluster(final YarnClient
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27451902
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -265,12 +266,32 @@ protected int run(String[] args) {
}
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27452411
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -89,15 +89,20 @@ public void setPrintStatusDuringExecution(boolean
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27452062
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -569,15 +590,33 @@ protected int executeProgram(PackagedProgram
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/542#discussion_r27452509
--- Diff:
flink-test-utils/src/main/java/org/apache/flink/test/util/TestEnvironment.java
---
@@ -80,7 +80,7 @@ public String getExecutionPlan() throws
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/542#issuecomment-87936262
While it is a big patch, with the additional comments I was able to follow
your changes. The main changes look good, so the rest I assume is side effect
to make the
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/542
[FLINK-1771] Add support for submitting single jobs to a detached YARN
session
With this change, users can submit a Flink job to a YARN cluster without
having a local client monitoring the
20 matches
Mail list logo
