[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-102374179 This looks good! Thanks for the update @andralungu! Will merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-99169722 Yap, that's what I had in mind! Only the class names are a bit too long. Maybe VertexCentricConfiguration and GSAConfiguration? Or something similar? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/635#issuecomment-99157184 Hi @vasia, The alternatives to having a single config class for all types of iterations are: - having two separate classes in spargel and in gsa = massive duplication of code - having an InterationConfiguration abstract class that VertexCentricIterationConfiguration and GatherSumApplyIterationConfiguration will inherit. I would personally go for the second approach! What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1942][gelly] GSA Iteration Configuratio...
GitHub user andralungu opened a pull request: https://github.com/apache/flink/pull/635 [FLINK-1942][gelly] GSA Iteration Configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/andralungu/flink gsaConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/635.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #635 commit ee0ab4d38616962a275e343c217bd1e6861f35cf Author: andralungu lungu.an...@gmail.com Date: 2015-04-27T19:14:12Z [FLINK-1942][gelly] GSA Iteration Configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
