[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-25 Thread shikhar
Github user shikhar closed the pull request at: https://github.com/apache/flink/pull/1636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1636#issuecomment-188874847 I would prefer to just add the compassable way, yes. Sorry that you now already put effort into this. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-25 Thread shikhar
Github user shikhar commented on the pull request: https://github.com/apache/flink/pull/1636#issuecomment-188874026 Thanks @StephanEwen, @aljoscha noted on the JIRA that it may be better to create a composable mechanism like `Any.of(,)` Until that exists, I do think this is

[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1636#issuecomment-188872638 Sorry for the late response, most people are fixing issues for the 1.0 release candidates. This actually looks like a nice addition. +1 for adding a

[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-14 Thread shikhar
GitHub user shikhar opened a pull request: https://github.com/apache/flink/pull/1636 [FLINK-3399] CountWithTimeoutTrigger trigger that fires once the number of elements in a pane reaches the given count or the timeout expires, whichever happens first You can merge this pull