Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79816123
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79816145
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112 @@
+/*
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79816134
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791053
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791682
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112 @@
+/*
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791290
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormatITCase.java
---
@@ -0,0 +1,112 @@
+/*
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791990
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -1,43 +0,0 @@
-
-
-
-
--- End diff --
I
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791171
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79477333
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -1,43 +0,0 @@
-
-
-
-
--- End diff --
I'm
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79477173
--- Diff:
flink-batch-connectors/flink-hbase/src/test/resources/log4j-test.properties ---
@@ -15,9 +15,16 @@
# specific language governing permissions
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79472506
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormat.java
---
@@ -0,0 +1,112 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469241
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -93,32 +102,45 @@ private HTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469197
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -93,32 +102,45 @@ private HTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469573
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -131,37 +153,27 @@ public T
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79470876
--- Diff:
flink-batch-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/TestTableInputFormat.java
---
@@ -0,0 +1,112 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79468879
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,15 +67,24 @@
protected
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79469513
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -131,37 +153,27 @@ public T
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73482199
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -328,7 +328,11 @@
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73480826
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -237,7 +244,7 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73382033
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -237,7 +244,7 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r73381826
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -328,7 +328,11 @@
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/flink/pull/2330
FLINK-4311 Fixed several problems in TableInputFormat
Question: Do you guys want a unit test for this?
In HBase itself I have done this in the past yet this required a large
chunk of
23 matches
Mail list logo
