[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-09-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2430#discussion_r80784331 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java --- @@

[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-09-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2430#discussion_r80783113 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java --- @@

[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-09-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2430#discussion_r80783750 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java --- @@

[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-09-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2430#discussion_r79390399 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java --- @@

[GitHub] flink pull request #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-08-27 Thread mushketyk
GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/2430 [FLINK-3874] Rewrite Kafka JSON Table sink tests Turned Kafka JSON Table sink tests into unit tests as discussed here: https://issues.apache.org/jira/browse/FLINK-3874 - [x] General