Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r78212144
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r78194763
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77970827
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
public class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77943543
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77787126
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77783497
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License for the
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77769044
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77768256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77651399
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77651201
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77650487
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77650617
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77650313
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77630918
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77630351
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ * Licensed
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r7763
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
---
@@ -32,4 +33,11 @@
//
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77629858
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java
---
@@ -46,13 +47,21 @@
/** if the slot is allocated, jobId
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77628362
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License for the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77629249
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -131,9 +149,16 @@ public RegistrationResponse
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77628600
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
public class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524626
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
@@ -15,11 +15,27 @@
* See the License
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524466
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77524239
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java
---
@@ -46,13 +47,21 @@
/** if the slot is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77523985
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
---
@@ -32,4 +33,11 @@
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77523806
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -0,0 +1,228 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77522737
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -131,9 +149,16 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77522339
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2463
[FLINK-4538][FLINK-4348] ResourceManager slot allocation protcol
This implements and tests the ResourceManager part of the protocol for slot
allocation.
- associates JobMasters with JobID
29 matches
Mail list logo
