[GitHub] flink pull request #2529: [FLINK-4241] [table] Cryptic expression parser exc...

2016-09-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2529


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2529: [FLINK-4241] [table] Cryptic expression parser exc...

2016-09-21 Thread twalthr
GitHub user twalthr opened a pull request:

https://github.com/apache/flink/pull/2529

[FLINK-4241] [table] Cryptic expression parser exceptions

Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful 
description of your changes.

- [x] General
  - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [x] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [x] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed

This PR improves the error message of the `ExpressionParser`. I tried my 
best but it is not easy to improve the message as we are using `RegexParsers`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twalthr/flink FLINK-4241

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2529


commit 7d8d69f8b52983ccf078adfa2a78bf0855ec7cf9
Author: twalthr 
Date:   2016-09-21T15:12:31Z

[FLINK-4241] [table] Cryptic expression parser exceptions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---