[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r83009444 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/PropertyRead.scala --- @@ -0,0 +1,33 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r83008188 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowIntervalTypeInfo.scala --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r83000595 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/windows/Session.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82999720 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowIntervalTypeInfo.scala --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82993938 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/PropertyRead.scala --- @@ -0,0 +1,33 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82991170 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala --- @@ -23,6 +23,8 @@ import

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82990475 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala --- @@ -27,48 +27,65 @@ import

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82990268 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/properties.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82989243 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/windows/Session.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82988652 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/windows/Session.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82899030 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/Aggregate.scala --- @@ -19,6 +19,7 @@ package

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82964364 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowIntervalTypeInfo.scala --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82901298 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,873 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82884874 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/aggregations.scala --- @@ -18,12 +18,15 @@ package

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82886893 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/properties.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82880181 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/windows/Session.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82968570 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/TimeIntervalTypeInfo.scala --- @@ -24,14 +24,14 @@ import

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82971688 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/PropertyRead.scala --- @@ -0,0 +1,33 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82899800 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala --- @@ -23,6 +23,8 @@ import

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82964905 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowIntervalTypeInfo.scala --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82971868 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/PropertyCollector.scala --- @@ -0,0 +1,42 @@ +/* +

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82887623 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala --- @@ -27,48 +27,65 @@ import

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82186936 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -325,33 +337,42 @@ trait

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82177134 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82177163 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82176556 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82171490 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82170972 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82170078 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147739 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151066 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82144274 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82152829 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147669 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151050 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147584 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147461 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151146 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82150960 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82150850 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82149847 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82149863 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82146791 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -497,3 +501,95 @@ case class

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82141352 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -55,28 +56,27 @@ case class

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82140542 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82133014 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82132367 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82132349 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82131749 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-06 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82129916 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -325,33 +337,42 @@ trait

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82009076 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/windowDsl.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82008309 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/windowDsl.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82006797 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/WordCountTable.scala --- @@ -50,6 +50,10 @@ object WordCountTable {

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82006252 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82002196 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81998716 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81997213 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81851322 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81858699 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81862041 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81857880 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -325,33 +337,42 @@ trait

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81852219 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81971150 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81860022 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81971046 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81945161 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -55,28 +56,27 @@ case class

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81970900 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalWindow.scala --- @@ -0,0 +1,35 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81957188 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -497,3 +501,95 @@ case class

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81861775 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81850803 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81857075 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/windowDsl.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81857293 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/windowDsl.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed to the

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81861356 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81852394 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81862223 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81970778 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/LogicalWindow.scala --- @@ -0,0 +1,35 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81860061 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81847736 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -675,11 +692,77 @@ class GroupedTable( *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81983925 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81852306 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81976580 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81854254 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/WordCountTable.scala --- @@ -50,6 +50,10 @@ object WordCountTable {

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-10-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r81859596 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + *

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

2016-09-28 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2562 [FLINK-4691] [table] Add group-windows for streaming tables This PR implements Tumble, Slide, Session group-windows for streaming tables as described in FLIP-11. It adds API, validation, logical