[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r8653 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/ByteStreamStateHandle.java --- @@ -20,62 +20,49 @@ import

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82221594 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV1Serializer.java --- @@ -290,6 +290,7 @@ public static

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82221108 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java --- @@ -219,7 +218,7 @@ public void

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82216509 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -259,28 +263,29 @@ public void

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82213262 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescalingITCase.java --- @@ -663,28 +826,42 @@ public Integer snapshotState(long

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82217757 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/ByteStreamStateHandle.java --- @@ -20,62 +20,49 @@ import

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82211635 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java --- @@ -219,7 +218,7 @@ public void write(byte[]

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82211023 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java --- @@ -297,7 +296,7 @@ public StreamStateHandle

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-06 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82211497 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV1Serializer.java --- @@ -290,6 +290,7 @@ public static void

[GitHub] flink pull request #2584: [FLINK-4731] Bugfix for HeapKeyedStateBackend scal...

2016-10-04 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/2584 [FLINK-4731] Bugfix for HeapKeyedStateBackend scale-in and additional tests in RescalingITCase Restoring the HeapKeyedStateBackend was broken in case that parallelism is reduced. The