Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86138204
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -377,11 +378,79 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86138673
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -377,11 +378,79 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86138263
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -377,11 +378,79 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86138100
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -377,11 +378,79 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86127428
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -377,11 +378,79 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86111954
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user tonycox commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86108721
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user tonycox commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86090398
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86089087
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user tonycox commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86081029
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r86061549
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85732909
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala
---
@@ -153,17 +153,42 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85732797
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/PowerCallGen.scala
---
@@ -0,0 +1,51 @@
+/*
+ *
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85732582
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala
---
@@ -153,17 +153,42 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85732685
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala
---
@@ -153,17 +153,42 @@ object
GitHub user tonycox reopened a pull request:
https://github.com/apache/flink/pull/2686
[FLINK-4743] The sqrt/power function not accept the real data types.
Add supporting of variety types on "power" function. Add casting for Float
and BigDecimal.
You can merge this pull request
Github user tonycox closed the pull request at:
https://github.com/apache/flink/pull/2686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tonycox commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85514611
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/PowerExpressionTest.scala
---
@@ -0,0 +1,149 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85218584
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/PowerExpressionTest.scala
---
@@ -0,0 +1,149 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2686#discussion_r85217190
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/AggregationsITCase.scala
---
@@ -258,4 +258,22 @@ class
GitHub user tonycox opened a pull request:
https://github.com/apache/flink/pull/2686
[FLINK-4743] The sqrt/power function not accept the real data types.
Add supporting of variety types on "power" function. Add casting for Float
and BigDecimal.
You can merge this pull request into
22 matches
Mail list logo
