[GitHub] flink pull request #2918: [FLINK-5214] Clean up checkpoint data in case of a...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2918


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2918: [FLINK-5214] Clean up checkpoint data in case of a...

2016-12-01 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/2918

[FLINK-5214] Clean up checkpoint data in case of a failing checkpoint 
operation

Adds exception handling to the stream operators for the snapshotState 
method. In case of an
exception while performing the snapshot operation, all until then 
checkpointed data will
be discarded/deleted. This makes sure that a failing checkpoint operation 
won't leave
orphaned checkpoint data (e.g. files) behind.

Add test case for FsCheckpointStateOutputStream

Add RocksDB FullyAsyncSnapshot cleanup test

Add proper state cleanup tests for window operator

Add state cleanup test for failing snapshot call of 
AbstractUdfStreamOperator

cc @StephanEwen

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink fixTaskCheckpointFailure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2918.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2918


commit 35fc74dd501fc49aa0b55f415c85c2140206220a
Author: Till Rohrmann 
Date:   2016-12-01T12:25:05Z

[FLINK-5214] Clean up checkpoint data in case of a failing checkpoint 
operation

Adds exception handling to the stream operators for the snapshotState 
method. In case of an
exception while performing the snapshot operation, all until then 
checkpointed data will
be discarded/deleted. This makes sure that a failing checkpoint operation 
won't leave
orphaned checkpoint data (e.g. files) behind.

Add test case for FsCheckpointStateOutputStream

Add RocksDB FullyAsyncSnapshot cleanup test

Add proper state cleanup tests for window operator

Add state cleanup test for failing snapshot call of 
AbstractUdfStreamOperator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---