Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3086
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95411011
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -28,6 +28,9 @@ if [ "$1" == "jobmanager" ]; then
echo "config file: " && grep
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95411497
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -36,9 +39,9 @@ elif [ "$1" == "taskmanager" ]; then
echo "Starting Task Manager"
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95410892
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure Flink
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95401803
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95384257
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95384182
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user kaelumania commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95383742
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -36,9 +39,9 @@ elif [ "$1" == "taskmanager" ]; then
echo "Starting Task Manager"
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95382374
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -36,9 +39,9 @@ elif [ "$1" == "taskmanager" ]; then
echo "Starting Task Manager"
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3086#discussion_r95381935
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,9 +22,9 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
GitHub user kaelumania opened a pull request:
https://github.com/apache/flink/pull/3086
Improve docker setup
Improves the overall docker setup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaelumania/flink improve-docker-setup
11 matches
Mail list logo