[GitHub] flink pull request #3337: [FLINK-5825][UI]make the cite path relative to sho...

2017-02-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #3337: [FLINK-5825][UI]make the cite path relative to sho...

2017-02-16 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request:

https://github.com/apache/flink/pull/3337

[FLINK-5825][UI]make the cite path relative to show it correctly

In yarn mode, the web frontend url is accessed from yarn in format like 
"http://spark-91-206:8088/proxy/application_1487122678902_0015/";, and the 
running job page's url is 
"http://spark-91-206:8088/proxy/application_1487122678902_0015/#/jobs/9440a129ea5899c16e7c1a7e8f2897b3";.
One .png file called "horizontal.png", which is very small can not be 
loaded in that mode, because in "index.styl" it is cited as absolute path.
We should make the path relative.

- [ ] Tests & Build
LATER I will paste difference between before and after.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WangTaoTheTonic/flink FLINK-5825

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3337


commit c2e2711b2f815a4aa1b9c8be2478c963c41da245
Author: WangTaoTheTonic 
Date:   2017-02-17T06:48:14Z

make the cite path relative to show it correctly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---