[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132691900 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -314,5 +314,34 @@ class SqlITCase

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132703597 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1181,8 +1188,12 @@ abstract class

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132690201 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1172,6 +1172,13 @@ abstract class

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132703400 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1193,12 +1204,18 @@ abstract class

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132689501 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1193,12 +1204,18 @@ abstract class

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-04 Thread yestinchen
GitHub user yestinchen opened a pull request: https://github.com/apache/flink/pull/4479 [FLINK-7309][hotfix] fix NullPointerException when selecting null fields ## What is the purpose of the change This pull request addresses FLINK-7309, adds null check before applying