Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4639
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140516796
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140455425
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140455067
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140454362
--- Diff:
flink-core/src/main/java/org/apache/flink/util/WrappingProxyUtil.java ---
@@ -27,10 +27,16 @@ private WrappingProxyUtil() {
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140448606
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140452104
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/AbstractCloseableRegistryTest.java
---
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r140449401
--- Diff:
flink-core/src/main/java/org/apache/flink/util/WrappingProxyUtil.java ---
@@ -27,10 +27,16 @@ private WrappingProxyUtil() {
throw
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r136879648
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r136877817
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r136877616
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4639#discussion_r136877433
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -61,13 +75,14 @@ public final void registerClosable(C
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4639
[FLINK-7524] Remove potentially blocking behaviour from AbstractCloseâ¦
â¦ableRegistry
## What is the purpose of the change
This PR removes potential for blocking
13 matches
Mail list logo