Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5107
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155245771
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242826
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown() {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242900
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown() {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155242108
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155240139
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155237910
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown()
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155225461
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155225963
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -86,122 +125,143 @@ public static void teardown()
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155229002
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/InMemorySubmittedJobGraphStore.java
---
@@ -0,0 +1,90 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r155225574
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -507,6 +514,41 @@ public void handleError(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154748301
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -244,7 +302,32 @@ protected JobManagerRunner
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154747386
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -534,6 +536,40 @@ public void handleError(final Exception
GitHub user GJL reopened a pull request:
https://github.com/apache/flink/pull/5107
[FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher
## What is the purpose of the change
The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore
instance. Hence,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154357254
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -534,6 +536,40 @@ public void handleError(final
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154359352
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5107
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320952
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154320903
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -117,84 +135,78 @@ public void testJobSubmission() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5107#discussion_r154128004
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -246,5 +258,11 @@ protected JobManagerRunner
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5107
[FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher
## What is the purpose of the change
The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore
instance. Hence,
22 matches
Mail list logo
