[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5406


---

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5406#discussion_r165916481
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
@@ -108,7 +108,7 @@
 * individually accepted or rejected by returning the collection of 
accepted
 * slot offers.
 *
-* @param taskManagerLocation from which the slot offers originate
+* @param taskManagerLocation from which the slot offer originates
--- End diff --

this method on the other hand offers multiple slots, so plural makes more 
sense.


---

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5406#discussion_r165807233
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
@@ -90,11 +90,11 @@
CompletableFuture releaseTaskManager(final ResourceID 
resourceId);
 
/**
-* Offers a slot to the {@link SlotPool}. The slot offer can be 
accepted or
+* Offers a slot to the {@link SlotPool}. The slot offers can be 
accepted or
 * rejected.
 *
-* @param taskManagerLocation from which the slot offer originates
-* @param taskManagerGateway to talk to the slot offerer
+* @param taskManagerLocation from which the slot offers originate
+* @param taskManagerGateway to talk to the slot offers
--- End diff --

the previous version was correct


---

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5406#discussion_r165807228
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
@@ -109,7 +109,7 @@
 * slot offers.
 *
 * @param taskManagerLocation from which the slot offers originate
-* @param taskManagerGateway to talk to the slot offerer
+* @param taskManagerGateway to talk to the slot offers
--- End diff --

the previous version was correct


---

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/5406#discussion_r165807220
  
--- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
@@ -90,11 +90,11 @@
CompletableFuture releaseTaskManager(final ResourceID 
resourceId);
 
/**
-* Offers a slot to the {@link SlotPool}. The slot offer can be 
accepted or
+* Offers a slot to the {@link SlotPool}. The slot offers can be 
accepted or
 * rejected.
 *
-* @param taskManagerLocation from which the slot offer originates
-* @param taskManagerGateway to talk to the slot offerer
+* @param taskManagerLocation from which the slot offers originate
--- End diff --

given that this method offers a single slot using singular makes more sense


---