[GitHub] flink pull request #5505: [FLINK-8538][table]Add a Kafka table source factor...

2018-02-23 Thread xccui
Github user xccui closed the pull request at:

https://github.com/apache/flink/pull/5505


---


[GitHub] flink pull request #5505: [FLINK-8538][table]Add a Kafka table source factor...

2018-02-16 Thread xccui
GitHub user xccui opened a pull request:

https://github.com/apache/flink/pull/5505

[FLINK-8538][table]Add a Kafka table source factory with JSON format support

## What is the purpose of the change

This PR adds Kafka JSON table source factories for different Kafka versions.

## Brief change log

- Adds a `Kafka` connector descriptor and a corresponding `KafkaValidator`.
- Adds a `KafkaJsonTableSourceFactory` and different version specific 
implementations.
- Adds a method to get the column numbers in `TableSchema`.
- Adds `equals()` and `hashCode()` methods for `KafkaTableSource` and 
`KafkaJsonTableSource`.

**Note:** the rowtime setting has not been implemented yet as I think a 
more friendly API to get the rowtime attributes should be provided in 
`DescriptorProperties`.

## Verifying this change

This change can be verified by the tests added in 
`KafkaJsonTableFromDescriptorTestBase` and the other sub-classes. However, they 
are temporarily commented.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (**yes**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (**yes**)
  - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xccui/flink FLINK-8538

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5505


commit 3da847507b65047a3fd02058596f6f712a9332de
Author: Xingcan Cui 
Date:   2018-02-12T10:11:36Z

[FLINK-8538][table]Add a Kafka table source factory with JSON format support




---