Github user pnowojski closed the pull request at:
https://github.com/apache/flink/pull/5572
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170875167
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkThroughputBenchmarkTests.java
---
@@ -52,6
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170873853
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -187,7 +185,6 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170631511
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -219,6 +219,14 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170600612
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
---
@@ -206,7 +201,7 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170557786
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
---
@@ -428,13 +455,15 @@ private
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170589597
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -332,8 +332,8 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170573898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -187,7 +185,6 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170560833
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -65,9 +67,8 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170589453
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -319,7 +319,7 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170585362
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadTask.java
---
@@ -447,6 +447,8 @@ private void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170574788
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -242,6 +239,22 @@ public boolean
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170590385
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkThroughputBenchmarkTests.java
---
@@ -52,6 +52,14
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170562983
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -208,7 +208,7 @@ public
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170560655
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -48,6 +48,8 @@
/** Flag
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5572
[FLINK-8694][runtime] Fix notifyDataAvailable race condition
This fixes two bugs in network stack:
https://issues.apache.org/jira/browse/FLINK-8760
16 matches
Mail list logo